Skip to content

Conversation

@kdamball
Copy link
Contributor

@kdamball kdamball commented Feb 10, 2022

Support template flag for typescript(--typescript/-ts) & JS(--javascript/-js)

Usage: @contentful/create-contentful-app init my-contentful-app --javascript

Copy link
Contributor

@andipaetzold andipaetzold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine 👍

.option('--javascript, -js')
.option('--typescript, -ts')
.action(async (opts) => {
console.log()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 why is that here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@andipaetzold andipaetzold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just that console.log seems wrong

@andipaetzold
Copy link
Contributor

I think you need to run npm i on root level and then also tests should be green.

@kdamball
Copy link
Contributor Author

Lerna strikes again

@kdamball kdamball merged commit a1f0b26 into canary Feb 11, 2022
@kdamball kdamball deleted the js-ts branch February 11, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants