Skip to content

feat: Add example option to app bootstrap #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 18, 2022
Merged

feat: Add example option to app bootstrap #875

merged 7 commits into from
Feb 18, 2022

Conversation

@colomolo
Copy link
Contributor

No description provided.

@colomolo colomolo marked this pull request as ready for review February 17, 2022 10:05
@colomolo colomolo requested a review from a team as a code owner February 17, 2022 10:05
shikaan
shikaan reviewed Feb 17, 2022
View reviewed changes
@colomolo colomolo requested a review from shikaan February 17, 2022 11:03
shikaan
shikaan approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@shikaan shikaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

There are a few references to examples instead of templates left in the template.ts file. The only place we should be using the word "example" is in makeContentfulExampleSource and the enum with the list of supported ones in my eyes

@colomolo
Copy link
Contributor Author

There are a few references to examples instead of templates left in the template.ts file. The only place we should be using the word "example" is in makeContentfulExampleSource and the enum with the list of supported ones in my eyes

Thanks! Fixed.

@colomolo colomolo merged commit aeff895 into canary Feb 18, 2022
@colomolo colomolo deleted the EXT-3437-example-flag branch February 18, 2022 08:51
@andipaetzold andipaetzold mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shikaan shikaan shikaan approved these changes

@andipaetzold andipaetzold Awaiting requested review from andipaetzold

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colomolo @shikaan