Skip to content

Update types of resources.search event #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Update types of resources.search event #744

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87c14de
feat: add locale property to resources.search event
BasKiers Jan 10, 2025
16269b0
fix: update resource.search event to match the type in functions-api …
BasKiers Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/requests/typings/resources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ export const RESOURCES_LOOKUP_EVENT = 'resources.lookup'
export type ResourcesSearchRequest = {
type: 'resources.search'
resourceType: string
query: string
limit?: number
query?: string
limit: number
locale?: string
pages?: {
nextCursor: string
}
Expand All @@ -25,7 +26,7 @@ export type ResourcesLookupRequest<L extends Record<string, Scalar[]> = Record<s
type: 'resources.lookup'
lookupBy: L
resourceType: string
limit?: number
limit: number
pages?: {
nextCursor: string
}
Expand Down