Skip to content

refactor: removes extensions from IDs API [EXT-3597] #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghepting merged 1 commit into from
Jul 7, 2023
Merged

refactor: removes extensions from IDs API [EXT-3597] #1579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@

- [EXT-3498] Adds `location.current` to Locations API
- [EXT-3595] Remove extensions from Dialog API
- [EXT-3597] Remove extensions from IDs API

# [4.22.0-alpha.1](https://github.com/contentful/ui-extensions-sdk/compare/v4.21.1...v4.22.0-alpha.1) (2023-06-29)
# [4.22.0](https://github.com/contentful/ui-extensions-sdk/compare/v4.21.1...v4.22.0) (2023-06-29)

### Features

Expand Down
2 changes: 1 addition & 1 deletion lib/navigator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default function createNavigator(channel: Channel, ids: IdsAPI): Navigato
openPageExtension: (opts) => {
return channel.call('navigateToPage', {
type: 'extension',
id: ids.extension,
id: ids.app,
...opts,
}) as Promise<any>
},
Expand Down
5 changes: 2 additions & 3 deletions lib/types/api.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,8 @@ export interface ParametersAPI<

export interface IdsAPI {
user: string
extension?: string
organization: string
app?: string
app: string
space: string
environment: string
environmentAlias?: string
Expand Down Expand Up @@ -326,7 +325,7 @@ export type ConfigAppSDK<InstallationParameters extends KeyValueMap = KeyValueMa
'ids'
> & {
/** A set of IDs actual for the app */
ids: Omit<IdsAPI, EntryScopedIds | 'extension' | 'app'> & { app: string }
ids: Omit<IdsAPI, EntryScopedIds | 'app'> & { app: string }
app: AppConfigAPI
}

Expand Down
2 changes: 1 addition & 1 deletion test/unit/cma.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ describe('createCMAClient()', function () {
environment: 'environment',
environmentAlias: 'environmentAlias',
organization: 'organization',
extension: 'extension',
app: 'app',
user: 'user',
field: 'field',
entry: 'entry',
Expand Down