Preserve punctuation autocomplete

core/autocomplete/completionProvider.ts

@@ -28,7 +28,7 @@
   constructAutocompletePrompt,
   languageForFilepath,
 } from "./constructPrompt.js";
-import { isOnlyPunctuationAndWhitespace } from "./filter.js";
+import { isOnlyWhitespace } from "./filter.js";
 import { AutocompleteLanguageInfo } from "./languages.js";
 import { postprocessCompletion } from "./postprocessing.js";
 import { AutocompleteSnippet } from "./ranking.js";
@@ -355,8 +355,12 @@
         return undefined;
       }
 
-      // Filter out unwanted results
-      if (isOnlyPunctuationAndWhitespace(outcome.completion)) {
+      /**
+       * This check is most likely not needed because we do trim the LLM output
+       * elsewhere in the code. That said, I'm not yet confident enough to
+       * remove this.
+       */
+      if (isOnlyWhitespace(outcome.completion)) {
         return undefined;
       }
 
@@ -364,7 +368,7 @@
       const completionToCache = outcome.completion;
       setTimeout(async () => {
         if (!outcome.cacheHit) {
           (await this.autocompleteCache).put(outcome.prefix, completionToCache);
         }
       }, 100);
 

core/autocomplete/filter.ts

@@ -1,4 +1,4 @@
-export function isOnlyPunctuationAndWhitespace(completion: string): boolean {
-  const punctuationAndWhitespaceRegex = /^[^\w\d\}\)\]]+$/;
-  return punctuationAndWhitespaceRegex.test(completion);
+export function isOnlyWhitespace(completion: string): boolean {
+  const whitespaceRegex = /^[\s]+$/;
+  return whitespaceRegex.test(completion);
 }

manual-testing-sandbox/Button.tsx

@@ -0,0 +1,15 @@
+import React from "react";
+
+export const Button = ({
+  onClick,
+  children,
+}: {
+  children: React.ReactNode;
+  onClick: () => void;
+}) => {
+  return (
+    <button className="btn btn-primary" onClick={onClick}>
+      {children}
+    </button>
+  );
+};