Skip to content

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Nov 19, 2025

Description

This setting wasn't being used. It was hardcoded to true because we use (user settings === false OR ide settings === false) logic to be safe. But a user interpreted that as hardcoding telemetry to always be on, which is not the case.


Summary by cubic

Removed dead JetBrains telemetry code and limited IDE telemetry checks to VS Code. This clarifies telemetry behavior and avoids confusion about it being always on in JetBrains.

  • Refactors
    • Removed isTelemetryEnabled from the IntelliJ IDE interface, implementation, and protocol handler.
    • Dropped the "isTelemetryEnabled" message type.
    • Updated doLoadConfig to only read IDE telemetry when ideType is "vscode".

Written for commit 12213fb. Summary will update automatically on new commits.

@RomneyDa RomneyDa requested a review from a team as a code owner November 19, 2025 19:14
@RomneyDa RomneyDa requested review from sestinj and removed request for a team November 19, 2025 19:14
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 19, 2025
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.


Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Nov 19, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 05cce29 into main Nov 19, 2025
84 of 89 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the dallin/jetbrains-telemetry branch November 19, 2025 23:27
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Nov 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
@sestinj
Copy link
Contributor

sestinj commented Nov 20, 2025

🎉 This PR is included in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Nov 20, 2025

🎉 This PR is included in version 1.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Nov 20, 2025

🎉 This PR is included in version 1.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Nov 20, 2025

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants