-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: remove dead isTelemetryEnabled code for jetbrains #8799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Review Complete Code Review Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 5 files
|
🎉 This PR is included in version 1.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.31.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This setting wasn't being used. It was hardcoded to true because we use (user settings === false OR ide settings === false) logic to be safe. But a user interpreted that as hardcoding telemetry to always be on, which is not the case.
Summary by cubic
Removed dead JetBrains telemetry code and limited IDE telemetry checks to VS Code. This clarifies telemetry behavior and avoids confusion about it being always on in JetBrains.
Written for commit 12213fb. Summary will update automatically on new commits.