-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Update pkg targets from node18 to node20 to match .nvmrc #8994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update pkg targets from node18 to node20 to match .nvmrc #8994
Conversation
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
2 similar comments
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
I have read the CLA Document and I hereby sign the CLA 3 out of 4 committers have signed the CLA. |
Update CLI documentation to reflect the new Node.js 20 minimum version requirement, aligning with the pkg target updates in #8994. Co-authored-by: nate <nate@continue.dev> Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
Update CLI documentation to reflect the new Node.js 20 minimum version requirement, aligning with the pkg target updates in continuedev#8994. Co-authored-by: nate <nate@continue.dev> Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 14 files
Documentation UpdatesUpdated the CLI documentation to reflect the new Node.js 20 minimum version requirement:
These changes align with:
|
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IliyaBrook looks like this is failing builds and other checks
Fixes CON-5033 All YAML examples in the reference docs now include the required fields (name, version, schema) to prevent validation errors and confusion for users. Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev> Co-authored-by: Dallin Romney <dallin@continue.dev>
Extends PR continuedev#8961 to cover model provider docs, model role docs, deep dive guides, and other documentation files that were missing the required name, version, and schema fields in their config.yaml examples. This ensures all YAML examples throughout the documentation are valid and prevent schema validation errors for users. Co-authored-by: nate <nate@continue.dev> Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
Standardized naming across all YAML examples in reference docs to use 'My Config' for better clarity. Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev> Co-authored-by: Dallin Romney <dallin@continue.dev>
Updated all YAML examples to use version 1.0.0 for better semantic versioning consistency. Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev> Co-authored-by: Dallin Romney <dallin@continue.dev>
Handle case where JSON content was parsed into an object by the tool call parser. If the arguments to the tool call are valid JSON (e.g. the model attempts to create a .json file) the earlier call to JSON.parse() will have deeply parsed the returned contents. If that has happened, convert back to string. Fixes: continuedev#8972
The original `pkg` package (v5.8.1) does not support Node 20, which is required by `.nvmrc` (v20.19.0). This causes the binary build to fail with "Error! No available node version satisfies 'node20'". Changes: - Replace `pkg@5.8.1` with `@yao-pkg/pkg@6.10.1` (actively maintained fork) - Update all pkg targets from `node18-*` to `node20-*` - Update bundle-binary.js to use `npx @yao-pkg/pkg` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 61 files (changes from recent commits).
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/customize/model-providers/more/morph.mdx">
<violation number="1" location="docs/customize/model-providers/more/morph.mdx:11">
P1: Invalid YAML structure in this code example. The header fields have incorrect indentation (5 spaces), and the list item below is missing its parent `models:` key. This example would fail to parse if a user copied it.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| <Tabs> | ||
| <Tab title="YAML"> | ||
| ```yaml title="config.yaml" | ||
| name: My Config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: Invalid YAML structure in this code example. The header fields have incorrect indentation (5 spaces), and the list item below is missing its parent models: key. This example would fail to parse if a user copied it.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/customize/model-providers/more/morph.mdx, line 11:
<comment>Invalid YAML structure in this code example. The header fields have incorrect indentation (5 spaces), and the list item below is missing its parent `models:` key. This example would fail to parse if a user copied it.</comment>
<file context>
@@ -8,13 +8,21 @@ Morph provides a fast apply model that helps you quickly and accurately apply co
<Tabs>
<Tab title="YAML">
```yaml title="config.yaml"
+ name: My Config
+ version: 0.0.1
+ schema: v1
</file context>
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Migrates from
pkgto@yao-pkg/pkgand updates build targets fromnode18tonode20to align with the project's.nvmrcfile which specifiesv20.19.0.The problem:
.nvmrcwas updated to Node 20.19.0 in commit1db5144b2(April 2025)pkgJson/*/package.jsonfiles still usenode18-*targetspkg@5.8.1package does not support Node 20 — it fails withError! No available node version satisfies 'node20'pkgcreates a corrupted binary that dumps JavaScript source code to stdout instead of running properlySolution:
pkg@5.8.1with@yao-pkg/pkg@6.10.1— an actively maintained fork that supports Node 20node18-*tonode20-*bundle-binary.jsto usenpx @yao-pkg/pkgFiles changed:
binary/package.json— replacedpkgdependency with@yao-pkg/pkg, updated targetsbinary/package-lock.json— regenerated with new dependencybinary/utils/bundle-binary.js— changednpx pkgtonpx @yao-pkg/pkgbinary/pkgJson/darwin-arm64/package.json—node18→node20binary/pkgJson/darwin-x64/package.json—node18→node20binary/pkgJson/linux-arm64/package.json—node18→node20binary/pkgJson/linux-x64/package.json—node18→node20binary/pkgJson/win32-arm64/package.json—node18→node20binary/pkgJson/win32-x64/package.json—node18→node20How I discovered this:
While building the JetBrains plugin locally, the resulting binary was broken — it output raw JavaScript code instead of functioning as expected. The marketplace binary (built with their CI) worked fine. After investigation, I found the mismatch between
.nvmrc(node20) and pkg targets (node18). Simply changing targets wasn't enough becausepkg@5.8.1doesn't support Node 20 — switching to@yao-pkg/pkgresolved the issue.AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
N/A - This is a build configuration fix with no UI changes.
Tests
No new tests required. This change aligns the build configuration with the already-specified Node.js version in
.nvmrc. The fix can be verified by:node -vshould showv20.x.xcd binary && npm installnpm run build(or specific platform:npm run build:linux-x64)./bin/linux-x64/continue-binaryBefore fix:
pkg@5.8.1fails withError! No available node version satisfies 'node20'After fix:
@yao-pkg/pkgSummary by cubic
Update pkg build targets to Node 20 across all platforms to match .nvmrc (v20.19.0) and fix broken local binaries built with Node 20. Also updates CLI docs to require Node 20.
Bug Fixes
Dependencies
Written for commit ecdb655. Summary will update automatically on new commits.