Skip to content

Conversation

@Patrick-Erichsen
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen commented Dec 4, 2025

Summary by cubic

Simplifies Hub onboarding with a focused two-step flow and makes Models Add-On the default path. Removes free-trial gating and onboarding-specific redirects for a cleaner, faster setup.

  • New Features

    • Two-step flow: Create account (auth.login(true) with IDE redirect) → Purchase credits (/settings/billing).
    • Onboarding opens on the Models Add-On tab by default.
  • Refactors

    • Removed free-trial alerts and trial-based tab ordering.
    • Simplified VS Code auth: always use the IDE redirect URI (removed onboarding-specific redirect).
    • Cleaned up OnboardingCard and tabs (dropped unused props/logic) and tightened card padding.

Written for commit e0fa577. Summary will update automatically on new commits.

@Patrick-Erichsen Patrick-Erichsen requested a review from a team as a code owner December 4, 2025 18:11
@Patrick-Erichsen Patrick-Erichsen requested review from sestinj and removed request for a team December 4, 2025 18:11
@continue
Copy link
Contributor

continue bot commented Dec 4, 2025

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

1 similar comment
@continue-development-app
Copy link

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 4, 2025
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

✅ Review Complete

This PR simplifies the hub onboarding flow by making the Models Add-On (credits) the default option and streamlining the account creation + purchase process. Here's my review:

Major Issues

Line extensions/vscode/src/stubs/WorkOsAuthProvider.ts:209-211 - Removed redirect URI logic could break authentication flow
The removed code handled different redirect URIs based on useOnboardingUri flag. Simply removing this without understanding why it was there could break the OAuth flow for certain scenarios. Need to verify this doesn't break auth redirects.

Security Concerns

No obvious security vulnerabilities introduced.

Functional Issues

Line gui/src/components/OnboardingCard/components/OnboardingModelsAddOnTab.tsx:26-31 - Missing error handling for auth
The handleCreateAccount function calls auth.login(true) but doesn't handle potential errors beyond a success check. Consider adding error handling and user feedback for failed login attempts.

Line gui/src/components/OnboardingCard/OnboardingCard.tsx:29-32 - Potential infinite re-render
The useEffect that sets the default tab has setActiveTab in dependencies which could cause re-renders. Consider using useCallback for setActiveTab or removing it from dependencies if it's stable.

Minor Suggestions

Line gui/src/components/OnboardingCard/components/OnboardingCardLanding.tsx:47-59 - Removed free trial exceeded logic
This removes the ability to show users they're out of credits. Consider if this messaging is still needed elsewhere in the UI.

Line gui/src/components/ReusableCard.tsx:31 - Changed padding from py-3 to !pt-0 pb-3
This asymmetric padding change (0 top, 3 bottom) should be documented or explained - it's breaking the consistent spacing pattern.

Line core/package-lock.json - Extensive dependency changes
The package-lock.json changes show many dependencies being marked as peer: true. This is a significant change to the dependency graph that should be verified to not break anything.

Overall Assessment

The code changes successfully simplify the onboarding flow to prioritize the Models Add-On option. However, there are concerns about:

  1. The removed OAuth redirect logic
  2. Missing error handling in auth flows
  3. Significant dependency graph changes that need verification

@continue
Copy link
Contributor

continue bot commented Dec 4, 2025

Documentation Review

I've reviewed the changes in this PR and no documentation updates are needed. Here's why:

Changes Made

  • Simplified onboarding flow to default to Models Add-On tab
  • Removed free trial alerts and landing page
  • Streamlined to two-step process: Create Account → Purchase Credits
  • Removed trial-specific redirect URIs

Documentation Status

The existing documentation remains accurate:

  1. Install guide () - Still correctly tells users to "Sign in to Mission Control to get started" without specifying the onboarding flow details
  2. Pricing page () - Correctly documents the free trial offering (50 chat requests, 2,000 autocomplete requests)
  3. No process documentation - The docs don't document the specific steps or tabs in the onboarding card, just that users should sign in

These are internal UX improvements to make onboarding clearer and faster. The user-facing documentation correctly describes the high-level process without being coupled to implementation details.

@continue
Copy link
Contributor

continue bot commented Dec 4, 2025

Documentation Review

I've reviewed the changes in this PR and no documentation updates are needed. Here's why:

Changes Made

  • Simplified onboarding flow to default to Models Add-On tab
  • Removed free trial alerts and landing page
  • Streamlined to two-step process: Create Account → Purchase Credits
  • Removed trial-specific redirect URIs

Documentation Status

The existing documentation remains accurate:

  1. Install guide - Still correctly tells users to 'Sign in to Mission Control to get started' without specifying the onboarding flow details
  2. Pricing page - Correctly documents the free trial offering (50 chat requests, 2,000 autocomplete requests)
  3. No process documentation - The docs don't document the specific steps or tabs in the onboarding card, just that users should sign in

These are internal UX improvements to make onboarding clearer and faster. The user-facing documentation correctly describes the high-level process without being coupled to implementation details.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 15 files

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Dec 4, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 4, 2025
@sestinj sestinj merged commit 37b4702 into main Dec 4, 2025
61 of 62 checks passed
@sestinj sestinj deleted the pe/onboarding branch December 4, 2025 22:07
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Dec 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
@github-actions github-actions bot added the tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys label Dec 4, 2025
@sestinj
Copy link
Contributor

sestinj commented Dec 4, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files. tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants