Skip to content

Conversation

@georgevreilly
Copy link
Collaborator

Summary

Much cleanup

Impact

Breaks internal uses of FlyingCloud

Limitations / TODO

Detail

  • flyingcloud command is now a Bash wrapper around the Python main
  • flyingcloud command supports --build (default), --run, and --kill operations.
  • flyingcloud.yaml has separate registry stanza
  • layer.yaml now has:
    • help and description fields
    • richer port mapping, host_port: container_ports(s)
  • Much cleanup of DockerBuildLayer:
    • replaced class-level attributes with instance attributes; simplified
    • do_run operation's default implementation runs an FC layer's
      in a Docker container with correct port mapping;
      also tunnels ports via docker-machine ssh, if needed.
    • do_kill operation cleans up Docker container, shuts down SSH port forwarding.
  • Improved main.py's YAML parsing
  • Moar tests!
  • python setup.py test runs the FlyingCloud tests

Testing

adamfeuer added a commit that referenced this pull request Mar 8, 2016
@adamfeuer adamfeuer merged commit 741ea4c into master Mar 8, 2016
@adamfeuer adamfeuer deleted the cleanup branch March 8, 2016 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants