fix: plan card unreadable on shopping list in dark mode#323
Conversation
The shopping list renders plan/menu entries with a `bg-gradient-to-r from-indigo-50 to-purple-50` background, but templates/base.html only had dark-mode overrides for other gradient combos (orange/yellow, gray/orange, green/blue, blue/purple, purple/pink, green/emerald). The indigo/purple gradient was missed, so in dark mode the plan card kept its light background while the text inside picked up the dark-mode light-gray color — rendering nearly invisible light-on-light text. Add dark-mode overrides for the indigo/purple gradient background and the matching `border-indigo-200` used on the plan card.
Code ReviewSummary: This correctly identifies and fixes the missing dark-mode override for the indigo/purple gradient used on plan cards. The approach is consistent with the existing pattern in What works well
Issues to consider1. Border color cascade interaction (minor) The gradient selector sets 2. Indigo vs purple border color (cosmetic)
3. Fragility of the gradient-enumeration approach (pre-existing, not introduced here) Every new gradient combination added to a template requires a corresponding entry in this block — and this PR is evidence that entries can be missed. A longer-term improvement (outside scope here) could be a single rule targeting any Test plan coverageThe test plan covers the happy path and a light-mode regression check. Also worth verifying that nested recipe entries within the plan card (the Verdict: Correct fix, follows existing conventions. Resolve the border cascade question before merging. |
Summary
Test plan