Improve update balance #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It extracts compound conditionals, adds some doc and emphasizes problems that arise from the current implementation such as the fact that max_allowed_balance it's either Integer or Float.
sauloperez
force-pushed
the
improve-update-balance
branch
from
dfe1f92 to
36a1063
Compare
enricostano
approved these changes
Jan 18, 2018
|
thanks for the quick review @enricostano! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds specs to
Account#update_balance, docs and refactors the method a bit. It extracts compound conditionals, adds some doc and emphasizes problems that arise from the current implementation such as the fact that max_allowed_balance it's either Integer or Float.