Cleanup gemfile #294
Merged
Cleanup gemfile #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/heroku/rails_12factor install instructions clearly state that this should go into the :production group in the Gemfile.
You can install in your dev system if you want. No need to add the extra maintainability cost to keep the dependency up to date.
According to its docs, "DEPRECATED: Use `travis lint` (from travis gem) instead". Also, "there's also an online version of this tool at lint.travis-ci.org."
As stated in its docs, it should go in those groups. It's not meant to be used in production.
No need for a comment. This is what git is for. To keep track of changes.
sauloperez
force-pushed
the
cleanup-gemfile
branch
from
32e41a7 to
0a6169d
Compare
|
Hey @markets! long time no see! fancy a small contribution? |
enricostano
approved these changes
Jan 25, 2018
|
tested 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Gemfile has been very abandoned. Besides the fact that there are almost no versions specified, there are a number of dependencies that are either deprecated or in the wrong Gemfile group. This is just a small step towards a better Gemfile.
Basically, I remove deprecated or unnecessary ones and I moved to production those that should only be there. Read the commits and their explanations for more details. I also took the chance to fix couple versions, given that I was at it.