Add staging environment #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauloperez
reviewed
Jan 30, 2018
|
|
||
| # Do not dump schema after migrations. | ||
| config.active_record.dump_schema_after_migration = false | ||
| end |
There was a problem hiding this comment.
is this a copy of production's config?
There was a problem hiding this comment.
Yep, we need to change the mail sender though
There was a problem hiding this comment.
Will do in another PR
enricostano
force-pushed
the
feature/staging
branch
from
3c1eb1a to
df9e063
Compare
enricostano
force-pushed
the
feature/staging
branch
from
df9e063 to
f0d061f
Compare
enricostano
commented
Jan 31, 2018
| if /^SMTP_(.*)$/ === k | ||
| [$1.downcase.to_sym, YAML.load(v)] | ||
| end | ||
| end.compact] |
There was a problem hiding this comment.
Understand this, document it and add staging stuff.
sauloperez
approved these changes
Feb 1, 2018
sauloperez
added a commit
that referenced
this pull request
Feb 9, 2018
This reverts commit 3a85664.
Matt-Yorkley
pushed a commit
to Matt-Yorkley/timeoverflow
that referenced
this pull request
Jun 21, 2018
Matt-Yorkley
pushed a commit
to Matt-Yorkley/timeoverflow
that referenced
this pull request
Jun 21, 2018
…/staging"" This reverts commit 3a85664.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config/secrets.yml