Introducing Persisters #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👧 👧 |
enricostano
reviewed
May 1, 2018
| describe '#save' do | ||
| it 'saves the post' do | ||
| post = Offer.new(organization: organization, user: user, category: category, title: 'Title') | ||
| persister = ::Persister::PostPersister.new(post) |
There was a problem hiding this comment.
Move both to let and reuse in examples
|
|
||
| describe '#update_attributes' do | ||
| it 'updates the attributes' do | ||
| persister = ::Persister::PostPersister.new(post) |
enricostano
suggested changes
May 1, 2018
| end | ||
| return unless organization | ||
|
|
||
| member = members.where(organization: organization).first_or_initialize |
There was a problem hiding this comment.
members would be the same as doing Member.where(user: self, ...
enricostano
approved these changes
May 1, 2018
Merged
sauloperez
approved these changes
May 2, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step on creating resources as side effects. In the future, when creating/updating a Post/Member/Transfer, it will create Events as side effects. Events will be used to create a kind of "Activity thread" section in a Time Bank.
About the naming: https://english.stackexchange.com/questions/206893/persister-or-persistor