Skip to content

Add conditions to PushNotification creation for Post #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2018
Merged

Add conditions to PushNotification creation for Post #408

merged 1 commit into from
Aug 22, 2018

Conversation

@enricostano
Copy link
Contributor

WAT

We only want to notify users that:

  • are active members of an organization
  • have push_notifications flag set to true

Fix #381

@enricostano enricostano self-assigned this Aug 20, 2018
@enricostano enricostano requested review from markets and mllocs August 20, 2018 10:42
@enricostano enricostano mentioned this pull request Aug 20, 2018
Merged
4 tasks
@sseerrggii
Copy link
Contributor

Tested!! 👍

@enricostano enricostano merged commit 6e8a71a into develop Aug 22, 2018
@enricostano enricostano deleted the feature/push-notifications-conditions branch August 22, 2018 11:23
@enricostano enricostano mentioned this pull request Aug 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markets markets markets approved these changes

@mllocs mllocs mllocs approved these changes

Assignees

@enricostano enricostano

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@enricostano @sseerrggii @markets @mllocs