remove destination accountable from transfer sources options #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morantron
force-pushed
the
fix/remove-destination-accountable-from-transfer-sources-options
branch
from
3555d49 to
f603758
Compare
|
Related 14eaad8 @sauloperez @sseerrggii any thought? |
|
Works fine tested on staging to: Transfer time link from:
Some checks failed on travis |
Morantron
force-pushed
the
fix/remove-destination-accountable-from-transfer-sources-options
branch
from
f603758 to
8e5d6ac
Compare
|
@Morantron if you rebase current |
Morantron
force-pushed
the
fix/remove-destination-accountable-from-transfer-sources-options
branch
from
8e5d6ac to
5f56bec
Compare
Morantron
force-pushed
the
fix/remove-destination-accountable-from-transfer-sources-options
branch
from
5f56bec to
af7e3a6
Compare
|
also deleted some tests, guess it makes sense |
|
@enricostano can we Merge it? |
enricostano
approved these changes
Apr 16, 2019
enricostano
deleted the
fix/remove-destination-accountable-from-transfer-sources-options
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on the multitransfers feature, I needed to use TransferSourcesOptions. In the context of that feature, when using TransferSourcesOptions, we don't know the destination accountable beforehand.
This PR removes the dependency on a destination accountable.