Feature/add phones search feature (only for managers) #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sseerrggii
changed the title
|
cool @sseerrggii 👍 I think this deserves a test case ensuring that search by phone is actually working, but +1 from my side! |
markets
force-pushed
the
feature/add-phones-search-managers
branch
2 times, most recently
from
1f69273 to
53aaf29
Compare
|
@sseerrggii @enricostano I just added that test case and rebased with current develop! This is now ready to review, test and merge! |
markets
approved these changes
Sep 25, 2019
sauloperez
approved these changes
Sep 30, 2019
enricostano
approved these changes
Oct 4, 2019
|
I have the same problem #514 (comment) |
|
sorry @sseerrggii 🙏 I can't help with that, but maybe after all changes done in infra during the past month, this was solved? |
|
Yes @markets I will test it again |
markets
force-pushed
the
feature/add-phones-search-managers
branch
from
53aaf29 to
d977d53
Compare
|
@sseerrggii just updated with current develop (with 💚 CI) |
|
Tested ✔️ |
|
👍 @sseerrggii |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #511