send weekly digest email in user's locale #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markets
force-pushed
the
emails_by_lang
branch
3 times, most recently
from
f3f050e to
0d1f442
Compare
sauloperez
requested changes
Mar 5, 2020
|
New approach as discussed in #556 (comment) and improved code coverage 💪 |
sauloperez
approved these changes
Mar 17, 2020
| org_locales.each_with_object({}) do |locale, hash| | ||
| hash[locale] = with_notifications.where(locale: locale) | ||
| end | ||
| end |
|
@sseerrggii this is ready for a quick round of testing. |
|
Tested 💚 Supereasy to test with sidekiq @markets 😉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #453