Skip to content

Upgrade rspec-rails from 3.8 to 3.9 #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

Upgrade rspec-rails from 3.8 to 3.9 #559

merged 1 commit into from
Mar 10, 2020

Conversation

@sauloperez
Copy link
Collaborator

@sauloperez sauloperez commented Mar 9, 2020 •
edited
Loading

If tests pass, better to stay up-to-date. Since I changed the Gemfile, dependabot should take over from now on and do it for us.

@sauloperez sauloperez requested a review from markets March 9, 2020 16:51
markets
markets approved these changes Mar 9, 2020
View reviewed changes
Copy link
Collaborator

@markets markets left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please! I already upgraded almost all gems in Rails 6 (#516) branch, but better if we can have some updates in develop 👌

@sauloperez sauloperez merged commit 5a1e4cd into develop Mar 10, 2020
@sauloperez sauloperez deleted the upgrade-rspec-rails branch March 10, 2020 07:37
@sauloperez sauloperez mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markets markets markets approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sauloperez @markets