Statistics code clean up #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markets
force-pushed
the
refactor_statistics
branch
from
bb63ddf to
63fb75a
Compare
markets
force-pushed
the
refactor_statistics
branch
from
feb7fd0 to
e4b6280
Compare
|
Tested!! 🌵 |
|
Locales edited at localeapp https://app.localeapp.com/projects/10031/translations/5898499?in_locale=30320 |
|
Thanks @sseerrggii, there are a couple of keys that can be deleted too: |
|
deleted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code needs further refactoring (probably move all logic to Services/Decorators), this is just a 1st minor step cleaning some details here and there and adding some tests.
SUMMARY OF CHANGES
statistics_prefix in files, methods, keys, routes, ...NOTES
Localeappafter merging this (https://github.com/coopdevs/timeoverflow/pull/600/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7) -> basically remove thestatistics_prefix under thestatistics.*scope. Also remove a couple of deprecated keys. @sseerrggii not sure if the rename can be done via the UI, alternatively we can check the CLI provided by the gem.EXTRAS
In the Admin section, add a "Recent Posts" box, inline with "Recent users" and "Recent Orgs" (489dab6)
REVIEW LINK (with no whitespace changes)
https://github.com/coopdevs/timeoverflow/pull/600/files?diff=unified&w=1
QA
Business logic was not changed at all, so a quick visit on each stats page to see everything keeps displaying data is enough :)