Skip to content

Conversation

@markets
Copy link
Collaborator

@markets markets commented Mar 15, 2021

Some Admin improvements:

  • Rename and refactor CsvDb => UserImporter + add specs (I have resurrected an old branch from @sauloperez https://github.com/coopdevs/timeoverflow/compare/improve-csv-user-import) 🔧
  • ActiveAdmin settings clean up ✂️ This file is very long and always out of date, better to check docs online ;p
  • ActiveAdmin improve menu: add current user + add all available locales (why not? 😺)
  • ActiveAdmin customize colors via sass vars, more inline with public part styles 🎨

Captura de pantalla 2021-03-16 a las 0 52 39

- Rename and refactor CsvDb => UserImporter + add specs (I have resurrected an old branch from Pau: https://github.com/coopdevs/timeoverflow/compare/improve-csv-user-import)
- ActiveAdmin settings clean up. This file is very long and always out of date, better to check docs online ;p
- ActiveAdmin improve menu: add current user + add all available locales

Co-authored-by: Pau Pérez Fabregat <saulopefa@gmail.com>
@markets markets added the wip label Mar 15, 2021
@markets markets changed the title Some Admin improvements: Admin improvements Mar 15, 2021
@markets markets removed the wip label Mar 15, 2021
@markets
Copy link
Collaborator Author

markets commented Mar 15, 2021

@sseerrggii ready to take a look 👀

@sseerrggii
Copy link
Contributor

Good Job @markets

I tested:

  • ✔️ Create organization
  • ✔️ Create user and assign to organization
  • ✔️ Import CSV of users

@sseerrggii sseerrggii merged commit 2f0442d into develop Mar 16, 2021
@markets markets deleted the user_importer branch March 16, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants