Skip to content

Conversation

@markets
Copy link
Collaborator

@markets markets commented Apr 17, 2021

WHAT?

Basically this 👉🏼 #614 (comment)

EXTRA

  • 💎 Add https://github.com/Shopify/bootsnap to speed up boot time (default gem since Rails 5.2)
  • ✂️ to-categories-dropdown.scss => we already have Bootstrap helpers for that
  • 🐛 fix some i18n keys (implicit scopes doesn't work well with partials and helpers, they are usually called in different places)
  • 🔧 code style refactor in Movement#other_side method + test

@markets
Copy link
Collaborator Author

markets commented Apr 17, 2021

@sseerrggii you got it! 💪🏼

Captura de pantalla 2021-04-17 a las 17 03 39

@markets markets force-pushed the random_enhancements branch from 8ee7df5 to 8c99e62 Compare April 18, 2021 15:54
@sseerrggii
Copy link
Contributor

cool 👍

Tested ✔️

@sseerrggii sseerrggii merged commit bbc8a70 into develop Apr 19, 2021
@sseerrggii sseerrggii deleted the random_enhancements branch April 19, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants