Skip to content

Conversation

@franpb14
Copy link
Collaborator

@franpb14 franpb14 commented Jan 6, 2024

Changes

  • now when te movements are created they use the same created at as the transfer

Note: If we didn't want to touch the rest of the app and only make this change in the import, we could use transfer.movements.update_all(created_at: transfer.created_at) in process_row after the transfer save. However, I believe it makes more sense as I placed it, to ensure consistency between transfer and movements at all times

@sseerrggii
Copy link
Contributor

Tested on staging ✔️
Works fine, thanks @franpb14

@markets markets merged commit 615e4d1 into develop Jan 7, 2024
@markets markets deleted the fix-transfer-movements branch January 7, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants