-
Notifications
You must be signed in to change notification settings - Fork 69
Adds a production ready docker environment #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @microstudi! Seems fine to me ✅, at least as far as I know Docker 😅
|
@microstudi I added some small comments 🙏🏼 and I see there is also 1 failing test: https://github.com/coopdevs/timeoverflow/actions/runs/7800180296/job/21272472836?pr=730#step:5:25. The rest seems good to me 👌🏼. |
|
@markets the failing test is due the update of the imagemagik library. I've fixed it but something happened with the upload coverage. |
This PR optimizes the application for its use in Docker images:
Testing
Run
Visit http:/localhost:3000/
Env vars summary:
RAILS_ENVproductionSECRET_KEY_BASErails secretDATABASE_URLpostgresql://user:password@host:port/databaseRAILS_SERVE_STATIC_FILESpublicfolder)trueRAILS_LOG_TO_STDOUTtrueRAILS_LOG_LEVELdebugfor maximum information)infoRAILS_MAX_THREADS1if multithreading is not desired)5RAILS_MIN_THREADSRAILS_MAX_THREADSvalueWEB_CONCURRENCY2RUN_SIDEKIQtrueRUN_RAILStrueQUEUE_ADAPTERsidekiqSIDEKIQ_CONCURRENCY5STORAGE_PROVIDERlocalandamazon)localFORCE_SSLfalseMAIL_LINK_HOSTmydomain.tld)MAIL_LINK_PROTOCOLhttpsSMTP_ADDRESSsmtp.mailgun.org)SMTP_PORT587)SMTP_DOMAINSMTP_USER_NAMESMTP_PASSWORDSMTP_AUTHENTICATIONplainSMTP_ENABLE_STARTTLS_AUTOtrueSMTP_OPENSSL_VERIFY_MODEnoneAWS_ACCESS_KEY_IDSTORAGE_PROVIDERisamazon)AWS_SECRET_ACCESS_KEYSTORAGE_PROVIDERisamazon)AWS_BUCKETSTORAGE_PROVIDERisamazon)AWS_REGIONSTORAGE_PROVIDERisamazon)ADMINSadmin@timeoverflow.org