extras: Improve Django filter for Rut
#878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #878 +/- ##
===========================================
+ Coverage 88.70% 88.82% +0.12%
===========================================
Files 38 38
Lines 3496 3498 +2
Branches 342 342
===========================================
+ Hits 3101 3107 +6
+ Misses 243 239 -4
Partials 152 152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jtrobles-cdd
force-pushed
the
improve-dj-filter-rut
branch
from
8e7d462 to
9576541
Compare
Refactor how substring lookups are handled for Chilean RUT fields in
Django filters, centralizing logic in the `RutFilter` class and
improving test coverage.
The main change is that the selection of the form field class for
substring lookups (like `contains` and `icontains`) is now handled
within `RutFilter.__init__()`, instead of being managed by a custom
`filter_for_lookup()` override in `SiiFilterSet`. This results in
cleaner code and more reliable behavior.
Key changes include:
- Refactoring and Logic Centralization:
- Moved the logic for selecting the appropriate `field_class` for
substring lookups (`contains`, `icontains`) from `SiiFilterSet.filter_for_lookup()`
into the `RutFilter` constructor, ensuring that substring lookups
use a plain `CharField` instead of a strict `RutField` that would
fail on invalid substrings.
- Test Enhancements:
- Added comprehensive tests for `RutFilter` to verify that the correct
`field_class` is chosen for each lookup expression, and for
`SiiFilterSet` to ensure `filter_for_lookup()` returns filters with
the correct field classes for different lookup types.
jtrobles-cdd
force-pushed
the
improve-dj-filter-rut
branch
from
9576541 to
c4df64a
Compare
|
jtrobles-cdd
added
enhancement
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how substring lookups are handled for Chilean RUT fields in Django filters, centralizing logic in the
RutFilterclass and improving test coverage.The main change is that the selection of the form field class for substring lookups (like
containsandicontains) is now handled withinRutFilter.__init__(), instead of being managed by a customfilter_for_lookup()override inSiiFilterSet. This results in cleaner code and more reliable behavior.Key changes include:
field_classfor substring lookups (contains,icontains) fromSiiFilterSet.filter_for_lookup()into theRutFilterconstructor, ensuring that substring lookups use a plainCharFieldinstead of a strictRutFieldthat would fail on invalid substrings.RutFilterto verify that the correctfield_classis chosen for each lookup expression, and forSiiFilterSetto ensurefilter_for_lookup()returns filters with the correct field classes for different lookup types.