extras: Django model field RutField does not validate DV of Rut
#882
+63
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #882 +/- ##
===========================================
- Coverage 88.82% 88.76% -0.07%
===========================================
Files 38 38
Lines 3498 3506 +8
Branches 342 345 +3
===========================================
+ Hits 3107 3112 +5
- Misses 239 241 +2
- Partials 152 153 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jtrobles-cdd
force-pushed
the
fix-rut-instance-dv-validation-dj-model-field
branch
from
a06fd3c to
110a532
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #882 +/- ##
===========================================
+ Coverage 88.81% 88.87% +0.05%
===========================================
Files 38 38
Lines 3497 3505 +8
Branches 342 345 +3
===========================================
+ Hits 3106 3115 +9
Misses 239 239
+ Partials 152 151 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jtrobles-cdd
force-pushed
the
fix-rut-instance-dv-validation-dj-model-field
branch
from
110a532 to
cd92471
Compare
In Django model field `RutField`, when field option `validate_dv` is enabled, the `to_python()` method does not validate the "digito verificador" if the input value is already an instance of `Rut`. This commit changes the implementation of `to_python()` so that the "digito verificador" is also validated for `Rut` instances when the `validate_dv` field option is enabled.
jtrobles-cdd
force-pushed
the
fix-rut-instance-dv-validation-dj-model-field
branch
from
cd92471 to
dd7561b
Compare
|
jtrobles-cdd
deleted the
fix-rut-instance-dv-validation-dj-model-field
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Django model field
RutField, when field optionvalidate_dvis enabled, theto_python()method does not validate the "digito verificador" if the input value is already an instance ofRut.This commit changes the implementation of
to_python()so that the "digito verificador" is also validated forRutinstances when thevalidate_dvfield option is enabled.