tests: Refactor and improve constants tests #888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor several test files for enum and constant classes to improve maintainability, consistency, and clarity. The main changes involve shifting from direct imports and usage of module-level constants/enums to storing them as class variables set up in `setUpClass()`, and enhancing the tests to check type consistency and equality for enum members. Key improvements include: - Consistent use of `setUpClass` to initialize class variables for constants and enums. - Enhanced type and equality checks for enum members in test cases. - Refactoring tests to use class variables instead of direct imports or module references. The most important changes are: **Test structure and setup improvements:** - Refactored all test classes in `test_dte_constants.py`, `test_rcv_constants.py`, `test_rtc_constants.py`, and `test_rut_constants.py` to use `setUpClass()` and store constants/enums as class variables, promoting consistency and easier maintenance. **Enum and constant validation enhancements:** - Updated enum tests to include checks for member value types (e.g., ensuring all values are of type `int` or `str`) and to verify that enum members are equal to their values or names where appropriate. - Improved tests for enums with integer values (like `TipoDte` and `RcvTipoDocto`) to confirm that enum members are also instances of `int`, and that casting their values to `int` yields the member itself. - For enums with string values, added checks to ensure that member values match their names. **Test code simplification:** - Replaced repetitive direct constant access in test methods with class variables, simplifying test code and reducing import clutter. **Documentation and clarity:** - Added docstrings and comments to clarify test purposes, such as in `TipoDteCediblesTest` for `TIPO_DTE_CEDIBLES`. These changes collectively make the test suite more robust, readable, and maintainable.
jtrobles-cdd
added
task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #888 +/- ##
========================================
Coverage 88.87% 88.87%
========================================
Files 38 38
Lines 3505 3505
Branches 345 345
========================================
Hits 3115 3115
Misses 239 239
Partials 151 151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor several test files for enum and constant classes to improve maintainability, consistency, and clarity. The main changes involve shifting from direct imports and usage of module-level constants/enums to storing them as class variables set up in
setUpClass(), and enhancing the tests to check type consistency and equality for enum members.Key improvements include:
setUpClassto initialize class variables for constants and enums.The most important changes are:
Test structure and setup improvements:
test_dte_constants.py,test_rcv_constants.py,test_rtc_constants.py, andtest_rut_constants.pyto usesetUpClass()and store constants/enums as class variables, promoting consistency and easier maintenance.Enum and constant validation enhancements:
intorstr) and to verify that enum members are equal to their values or names where appropriate.TipoDteandRcvTipoDocto) to confirm that enum members are also instances ofint, and that casting their values tointyields the member itself.Test code simplification:
Documentation and clarity:
TipoDteCediblesTestforTIPO_DTE_CEDIBLES.These changes collectively make the test suite more robust, readable, and maintainable.