Skip to content

Conversation

@svillegas-cdd
Copy link
Contributor

  • Implemented parse_taxpayer_data to parse taxpayer data from CTE HTML.
  • Added TaxpayerData and LastFiledDocument data models.
  • Created tests to validate parser functionality with sample HTML input.

Ref: https://app.shortcut.com/cordada/story/16534/

@svillegas-cdd svillegas-cdd requested a review from a team as a code owner September 12, 2025 15:50
@svillegas-cdd svillegas-cdd changed the title feat(cte): Add parser for "Datos del Contribuyente" cte: Add parser for "Datos del Contribuyente" Sep 12, 2025
@svillegas-cdd svillegas-cdd self-assigned this Sep 12, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR implements a parser for the "Datos del Contribuyente" (Taxpayer Data) section from CTE HTML content. It adds functionality to extract taxpayer information including start dates, activities, tax categories, and document filings.

  • Implemented parse_taxpayer_data function to parse taxpayer data from CTE HTML
  • Added TaxpayerData and LastFiledDocument data models with proper field definitions
  • Created comprehensive tests to validate parser functionality with sample HTML input

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/tests/test_data/sii-cte/cte_empty_f29.html Sample HTML test data containing CTE structure with taxpayer information
src/tests/test_cte_parsers.py Test cases for the new taxpayer data parser functionality
src/cl_sii/cte/parsers.py Implementation of parse_taxpayer_data parser function
src/cl_sii/cte/data_models.py New data models TaxpayerData and LastFiledDocument

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 97.01493% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.31%. Comparing base (5a63cfe) to head (6438d2a).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/cl_sii/cte/parsers.py 95.55% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #890      +/-   ##
===========================================
+ Coverage    89.17%   89.31%   +0.14%     
===========================================
  Files           40       40              
  Lines         3566     3632      +66     
  Branches       355      366      +11     
===========================================
+ Hits          3180     3244      +64     
  Misses         238      238              
- Partials       148      150       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@svillegas-cdd svillegas-cdd force-pushed the task/sc-16534--parse-datos-del-contribuyente branch 2 times, most recently from a82e219 to 892f19c Compare September 12, 2025 16:07
- Implemented `parse_taxpayer_data` to parse taxpayer data from CTE HTML.
- Added `TaxpayerData` and `LastFiledDocument` data models.
- Created tests to validate parser functionality with sample HTML input.

Ref: https://app.shortcut.com/cordada/story/16534/
@svillegas-cdd svillegas-cdd force-pushed the task/sc-16534--parse-datos-del-contribuyente branch from 892f19c to 6438d2a Compare September 16, 2025 13:54
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
49.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@svillegas-cdd svillegas-cdd merged commit 7a06ce8 into develop Sep 16, 2025
20 of 21 checks passed
@svillegas-cdd svillegas-cdd deleted the task/sc-16534--parse-datos-del-contribuyente branch September 16, 2025 14:13
@svillegas-cdd svillegas-cdd mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants