-
Notifications
You must be signed in to change notification settings - Fork 12
rcv: Improve checks for RCV Reclamado parser workaround #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rcv: Improve checks for RCV Reclamado parser workaround #892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request improves the RCV Reclamado parser by fixing a potential null reference issue in the preprocessing logic and adds comprehensive test coverage for the parser functionality.
- Enhanced the
Fecha Reclamofield preprocessing to handle cases where the value is alreadyNone - Added complete test implementation for
parse_rcv_compra_reclamado_csv_filewith multiple test scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/cl_sii/rcv/parse_csv.py | Fixed null check in RcvCompraReclamadoCsvRowSchema preprocessing |
| src/tests/test_rcv_parse_csv.py | Implemented comprehensive test for RCV reclamado parser with various data scenarios |
| src/tests/test_data/sii-rcv/RCV-compra-reclamado.csv | Added test CSV data file with valid and invalid entries |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aa4928b to
c635165
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #892 +/- ##
===========================================
+ Coverage 88.97% 89.17% +0.19%
===========================================
Files 40 40
Lines 3565 3566 +1
Branches 355 355
===========================================
+ Hits 3172 3180 +8
+ Misses 240 238 -2
+ Partials 153 148 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Updated `RcvCompraReclamadoCsvRowSchema.preprocess` workaround for `Fecha Reclamo` to check if variable is already `None` - Implemented test `test_parse_rcv_compra_reclamado_csv_file` to check multiple use cases for parser `RcvCompraReclamadoCsvRowSchema` Ref: https://app.shortcut.com/cordada/story/16601/
c635165 to
9096a3a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


RcvCompraReclamadoCsvRowSchema.preprocessworkaround forFecha Reclamoto check if variable is alreadyNonetest_parse_rcv_compra_reclamado_csv_fileto check multiple use cases for parserRcvCompraReclamadoCsvRowSchemaRef: https://app.shortcut.com/cordada/story/16601/