Skip to content

Conversation

@svillegas-cdd
Copy link
Contributor

  • Updated RcvCompraReclamadoCsvRowSchema.preprocess workaround for Fecha Reclamo to check if variable is already None
  • Implemented test test_parse_rcv_compra_reclamado_csv_file to check multiple use cases for parser RcvCompraReclamadoCsvRowSchema

Ref: https://app.shortcut.com/cordada/story/16601/

@svillegas-cdd svillegas-cdd self-assigned this Sep 15, 2025
@svillegas-cdd svillegas-cdd added bug Something isn't working component: rcv labels Sep 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves the RCV Reclamado parser by fixing a potential null reference issue in the preprocessing logic and adds comprehensive test coverage for the parser functionality.

  • Enhanced the Fecha Reclamo field preprocessing to handle cases where the value is already None
  • Added complete test implementation for parse_rcv_compra_reclamado_csv_file with multiple test scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/cl_sii/rcv/parse_csv.py Fixed null check in RcvCompraReclamadoCsvRowSchema preprocessing
src/tests/test_rcv_parse_csv.py Implemented comprehensive test for RCV reclamado parser with various data scenarios
src/tests/test_data/sii-rcv/RCV-compra-reclamado.csv Added test CSV data file with valid and invalid entries

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@svillegas-cdd svillegas-cdd force-pushed the task/sc-16601-typeerror-argument-of-type-nonetype-is-not-iterable branch from aa4928b to c635165 Compare September 15, 2025 15:40
@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.17%. Comparing base (f943840) to head (9096a3a).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #892      +/-   ##
===========================================
+ Coverage    88.97%   89.17%   +0.19%     
===========================================
  Files           40       40              
  Lines         3565     3566       +1     
  Branches       355      355              
===========================================
+ Hits          3172     3180       +8     
+ Misses         240      238       -2     
+ Partials       153      148       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Updated `RcvCompraReclamadoCsvRowSchema.preprocess` workaround for `Fecha Reclamo` to check if variable is already `None`
- Implemented test `test_parse_rcv_compra_reclamado_csv_file` to check multiple use cases for parser `RcvCompraReclamadoCsvRowSchema`

Ref: https://app.shortcut.com/cordada/story/16601/
@svillegas-cdd svillegas-cdd force-pushed the task/sc-16601-typeerror-argument-of-type-nonetype-is-not-iterable branch from c635165 to 9096a3a Compare September 15, 2025 15:44
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
16.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@svillegas-cdd svillegas-cdd marked this pull request as ready for review September 15, 2025 15:46
@svillegas-cdd svillegas-cdd requested a review from a team as a code owner September 15, 2025 15:46
@svillegas-cdd svillegas-cdd merged commit df794e1 into develop Sep 15, 2025
22 of 23 checks passed
@svillegas-cdd svillegas-cdd deleted the task/sc-16601-typeerror-argument-of-type-nonetype-is-not-iterable branch September 15, 2025 16:47
@svillegas-cdd svillegas-cdd mentioned this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working component: rcv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants