Skip to content

Conversation

@svillegas-cdd
Copy link
Contributor

  • Implemented parse_taxpayer_properties to parse property table from CTE HTML.
  • Added Property and TaxpayerProperties data models.
  • Created tests to validate parser functionality with sample HTML input.

Ref: https://app.shortcut.com/cordada/story/16536/

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds parsing functionality for the "Propiedades y Bienes Raíces" (Properties and Real Estate) section from CTE HTML documents.

  • Implemented a new parser function to extract property data from HTML tables
  • Added data models for individual properties and collections of taxpayer properties
  • Created comprehensive tests with mock HTML data to validate parsing functionality

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/cl_sii/cte/data_models.py Added Property and TaxpayerProperties data models with field validation
src/cl_sii/cte/parsers.py Implemented parse_taxpayer_properties function to extract property data from HTML
src/tests/test_cte_parsers.py Added test cases for the new parser functionality
src/tests/test_data/sii-cte/cte_empty_f29.html Added mock property data rows for testing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.35%. Comparing base (cf4db5e) to head (c357286).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/cl_sii/cte/data_models.py 87.23% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #895      +/-   ##
===========================================
+ Coverage    89.32%   89.35%   +0.03%     
===========================================
  Files           40       40              
  Lines         3634     3702      +68     
  Branches       366      375       +9     
===========================================
+ Hits          3246     3308      +62     
- Misses         238      241       +3     
- Partials       150      153       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@svillegas-cdd svillegas-cdd force-pushed the task/sc-16536-parse-propiedades-y-bienes-raices-cte branch 2 times, most recently from 1bf6603 to ce120ab Compare September 16, 2025 17:22
@svillegas-cdd svillegas-cdd marked this pull request as ready for review September 16, 2025 17:22
@svillegas-cdd svillegas-cdd requested a review from a team as a code owner September 16, 2025 17:22
- Implemented `parse_taxpayer_properties` to parse property table from CTE HTML.
- Added `Property` and `TaxpayerProperties` data models.
- Created tests to validate parser functionality with sample HTML input.

Ref: https://app.shortcut.com/cordada/story/16536/
@svillegas-cdd svillegas-cdd force-pushed the task/sc-16536-parse-propiedades-y-bienes-raices-cte branch from ce120ab to c357286 Compare September 16, 2025 19:19
@sonarqubecloud
Copy link

@svillegas-cdd svillegas-cdd merged commit 2179e41 into develop Sep 16, 2025
21 checks passed
@svillegas-cdd svillegas-cdd deleted the task/sc-16536-parse-propiedades-y-bienes-raices-cte branch September 16, 2025 19:35
@svillegas-cdd svillegas-cdd mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants