-
Notifications
You must be signed in to change notification settings - Fork 12
cte: Add parser for "Propiedades y Bienes Raíces" #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cte: Add parser for "Propiedades y Bienes Raíces" #895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds parsing functionality for the "Propiedades y Bienes Raíces" (Properties and Real Estate) section from CTE HTML documents.
- Implemented a new parser function to extract property data from HTML tables
- Added data models for individual properties and collections of taxpayer properties
- Created comprehensive tests with mock HTML data to validate parsing functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/cl_sii/cte/data_models.py | Added Property and TaxpayerProperties data models with field validation |
| src/cl_sii/cte/parsers.py | Implemented parse_taxpayer_properties function to extract property data from HTML |
| src/tests/test_cte_parsers.py | Added test cases for the new parser functionality |
| src/tests/test_data/sii-cte/cte_empty_f29.html | Added mock property data rows for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #895 +/- ##
===========================================
+ Coverage 89.32% 89.35% +0.03%
===========================================
Files 40 40
Lines 3634 3702 +68
Branches 366 375 +9
===========================================
+ Hits 3246 3308 +62
- Misses 238 241 +3
- Partials 150 153 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1bf6603 to
ce120ab
Compare
- Implemented `parse_taxpayer_properties` to parse property table from CTE HTML. - Added `Property` and `TaxpayerProperties` data models. - Created tests to validate parser functionality with sample HTML input. Ref: https://app.shortcut.com/cordada/story/16536/
ce120ab to
c357286
Compare
|



parse_taxpayer_propertiesto parse property table from CTE HTML.PropertyandTaxpayerPropertiesdata models.Ref: https://app.shortcut.com/cordada/story/16536/