Skip to content
This repository was archived by the owner on Apr 17, 2023. It is now read-only.

fix: make options.files optional #42

Merged
merged 1 commit into from
Mar 3, 2021
Merged

fix: make options.files optional #42

merged 1 commit into from
Mar 3, 2021

Conversation

@zaida04
Copy link
Member

@zaida04 zaida04 commented Mar 3, 2021

At the current state, RestManager#post requires you to supply a file array.
It shouldn't.
made it optional 😄.

@zaida04 zaida04 requested a review from didinele March 3, 2021 20:40
@zaida04 zaida04 self-assigned this Mar 3, 2021
@didinele
Copy link
Contributor

didinele commented Mar 3, 2021

this is the bane of my existance

@didinele didinele added this to the Next patch release (0.1.7) milestone Mar 3, 2021
@didinele didinele merged commit 7cdefd8 into main Mar 3, 2021
@didinele didinele deleted the fix/http-post branch March 3, 2021 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@didinele didinele didinele approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zaida04 zaida04

Labels

p: medium semver: patch

Projects

None yet

Milestone

Next patch release (0.1.7)

Development

Successfully merging this pull request may close these issues.

3 participants

@zaida04 @didinele