Skip to content
This repository was archived by the owner on Apr 17, 2023. It is now read-only.

Conversation

@didinele
Copy link
Contributor

@didinele didinele commented Mar 8, 2021

Please describe the changes this PR makes and why it should be merged:
This PR adds a meta issue template and also fixes a few cheeky issues with the existing templates and new README.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@didinele didinele requested a review from zaida04 March 8, 2021 07:18
Copy link
Member

@zaida04 zaida04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also include fixing the root readmes wonky icon in this PR?

@didinele
Copy link
Contributor Author

didinele commented Mar 8, 2021

Sure, just uncertain how to go about it. The old fix was just setting the width and height to 190 which I found was reasonable, but I think using something dynamic/responsive is just a much better approach.

How would we do that? I don't know.

@didinele
Copy link
Contributor Author

didinele commented Mar 8, 2021

Okay, found it

img {
  width: 100%;
  height: auto;
}

as a style does the trick, lemme try

@didinele didinele changed the title feat(repo): meta thread issue template feat(repo): meta thread issue template & other regressions Mar 8, 2021
@didinele didinele requested a review from zaida04 March 8, 2021 11:33
@zaida04 zaida04 merged commit 08d825f into main Mar 8, 2021
@zaida04 zaida04 deleted the feat/meta-issue-template branch March 8, 2021 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants