Update rendered-count _after_ async results have displayed #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that all async results are rendered.
|
LGTM /cc @Apfeluser |
lenovouser
pushed a commit
that referenced
this pull request
Oct 4, 2015
Update rendered-count _after_ async results have displayed
|
Thanks a lot! |
This was referenced Oct 5, 2015
This was referenced Oct 25, 2015
alexkiousis
pushed a commit
to grnet/webdns4
that referenced
this pull request
Dec 1, 2017
We were hitting: corejavascript/typeahead.js#8 We are using upstream's d60aed08 since no version is released yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-submitting twitter/typeahead.js#1212 here, since the original repo has all but been abandoned.
Change
Update rendered-count after async results have displayed. This ensures that all async results are rendered. Includes test.
/cc @CoreSystemDevelopment