Skip to content

cmd-koji-upload: properly support architectures.#968

Merged
darkmuggle merged 1 commit intocoreos:rhcos-4.3from
darkmuggle:rhcos-4.3
Dec 5, 2019
Merged

cmd-koji-upload: properly support architectures.#968
darkmuggle merged 1 commit intocoreos:rhcos-4.3from
darkmuggle:rhcos-4.3

Conversation

@darkmuggle
Copy link
Contributor

This fixes a number of architecture related bugs with the Koji upload
process, notably:

  • No longer assumes the running host's architecture. Architecture of a
    build is now discerned and enforced from the meta.json.
  • Allows selection of the architecture via --arch flag
  • When an artifact should be arch-aware, a pathing check is performed.

(cherry picked from commit 3f9bcd3)

This fixes a number of architecture related bugs with the Koji upload
process, notably:
- No longer assumes the running host's architecture. Architecture of a
  build is now discerned and enforced from the meta.json.
- Allows selection of the architecture via `--arch` flag
- When an artifact should be arch-aware, a pathing check is performed.

(cherry picked from commit 3f9bcd3)
@darkmuggle
Copy link
Contributor Author

/cc @miabbott @andymcc

@darkmuggle darkmuggle requested a review from miabbott December 5, 2019 00:05
Copy link
Member

@miabbott miabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@darkmuggle darkmuggle merged commit 4773bef into coreos:rhcos-4.3 Dec 5, 2019
@darkmuggle darkmuggle deleted the rhcos-4.3 branch December 5, 2019 16:45
jcajka pushed a commit to jcajka/coreos-assembler that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants