supermin-init-prelude: add timeout on udevadm trigger --settle and make non-fatal
#3368
Conversation
jlebon
force-pushed
the
pr/udevadm-trigger
branch
from
84022d7 to
de01172
Compare
…fatal We hit a case on ppc64le where this just hung forever. Let's add a timeout on it. And since this is best effort, let's just ignore any errors from the command. If a symlink is missing, we'll just error out with a clearer error down the line anyway.
jlebon
force-pushed
the
pr/udevadm-trigger
branch
from
de01172 to
1ea4d52
Compare
|
/cherry-pick rhcos-4.13 |
|
@jlebon: new pull request could not be created: failed to create pull request against coreos/coreos-assembler#rhcos-4.13 from head openshift-cherrypick-robot:cherry-pick-3368-to-rhcos-4.13: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between coreos:rhcos-4.13 and openshift-cherrypick-robot:cherry-pick-3368-to-rhcos-4.13"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Oh wait, rhcos-4.13 does have it. My local branch of it wasn't up to date. So then we only need |
|
@jlebon: new pull request created: #3913 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
We hit a case on ppc64le where this just hung forever. Let's add a timeout on it.
And since this is best effort, let's just ignore any errors from the command. If a symlink is missing, we'll just error out with a clearer error down the line anyway.