Skip to content

cmd-osbuild: add comment for relevance of rootful codepath #4260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

cmd-osbuild: add comment for relevance of rootful codepath #4260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/cmd-osbuild
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,10 @@ main() {

outdir=$(mktemp -p "${tmp_builddir}" -d)
if has_privileges && [ "${COSA_NO_KVM:-}" == "1" ]; then
cmd="env" # run outside of supermin if we are root already
# Run outside of supermin if we are root already. This is useful
# mostly on riscv where /dev/kvm isn't really supported by any
# hardware right now (2025/08).
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase "right now" is a bit redundant given that a specific date is provided in parentheses. For conciseness and clarity, you could remove "right now".

# hardware (2025/08).

cmd="env"
else
cmd="runvm_with_cache"
fi
Expand Down
Loading