Skip to content

oscontainer beautification and checking #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2019
Merged

oscontainer beautification and checking #655

merged 2 commits into from
Jul 24, 2019

Conversation

@ashcrow
Copy link
Member

@ashcrow ashcrow commented Jul 24, 2019 •
edited
Loading

  • updates oscontainer.py to pass make check/make flake8
  • removes unused imports
  • pulls code out of global scope
  • enables check against the file in CI

Will need a backport to rhcos-4.2

ashcrow added 2 commits July 24, 2019 10:03
@ashcrow
src/oscontainer.py: flake8 fixes
b8540a9 
Signed-off-by: Steve Milner <smilner@redhat.com>
@ashcrow
Makefile: Enable check for oscontainer.py
d7f2388 
Signed-off-by: Steve Milner <smilner@redhat.com>
yuqi-zhang
yuqi-zhang approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

miabbott
miabbott approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@miabbott miabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miabbott miabbott merged commit c2a8682 into coreos:master Jul 24, 2019
@ashcrow ashcrow mentioned this pull request Jul 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@darkmuggle darkmuggle Awaiting requested review from darkmuggle

+1 more reviewer

@miabbott miabbott miabbott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashcrow @miabbott @yuqi-zhang