create_disk: Drop the root= and rootflags= kargs by default #786
Conversation
darkmuggle
left a comment
darkmuggle
left a comment
There was a problem hiding this comment.
I think you'll see a problem with Ignition.
https://github.com/coreos/ignition-dracut/blob/master/dracut/30ignition/ignition-generator#L52-L53
This helps complete the move in coreos/coreos-assembler#786 to have our rootflags be fully dynamic. It's also necessary for ext4+fsverity by default.
This helps complete the move in coreos/coreos-assembler#786 to have our rootflags be fully dynamic. It's also necessary for ext4+fsverity.
This helps complete the move in coreos/coreos-assembler#786 to have our rootflags be fully dynamic. It's also necessary for ext4+fsverity.
That's about |
cgwalters
force-pushed
the
drop-rootflag
branch
from
b1de455 to
1da3e9b
Compare
|
OK, RHCOS merged coreos/fedora-coreos-config#187 - this should be good to go! |
|
Side note: Probably our CI here should just run |
Hmm. |
This is prep for reprovisioning the rootfs: coreos/fedora-coreos-tracker#94 Requires: coreos/fedora-coreos-config#187 (Do not merge until RHCOS has also rebased to FCOS with that change) Closes: coreos#781
cgwalters
force-pushed
the
drop-rootflag
branch
from
1da3e9b to
73d7f93
Compare
Going to call that one a flake. I had a full |
| fi | ||
| ostree pull-local "$ostree" "$ref" --repo rootfs/ostree/repo $remote_arg | ||
| ostree admin os-init "$os_name" --sysroot rootfs | ||
| allkargs='root=/dev/disk/by-label/root rootflags=defaults,prjquota rw $ignition_firstboot' |
There was a problem hiding this comment.
Hmm, looks like we're losing rw here, was that on purpose?
There was a problem hiding this comment.
Yep, I don't think anything parses it without root= causing the systemd generator to run. In any case it's cleaner to have our systemd unit do it.
|
Gah, this breaks rebooting 😢 |
|
Unfortunately I'm seeing new flakes in qemu userspace networking which seemed to mask errors from this one. |
3 participants
This is prep for reprovisioning the rootfs:
coreos/fedora-coreos-tracker#94
Requires: coreos/fedora-coreos-config#187
(Do not merge until RHCOS has also rebased to FCOS with that change)
Closes: #781