clientv3: fix dialer for maintenance API#9880
Closed
gyuho wants to merge 2 commits intoetcd-io:masterfrom
Closed
Conversation
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
If a given dial target is different than balancer connection endpoint, the dial target should be used. Fixed all maintenance API calls. Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Contributor
Author
|
@jpbetz Think we need improve picker generator logic. Let me create a separate issue to explain the root cause and proposed solution. |
Contributor
|
@gyuho Sounds good. Let me know if you need me to pitch in on any code changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without patch
So gRPC is passing the endpoint used for initial client connection to the custom dialer, not the endpoint target that client passes to the dial method. So, we need special handling when two given hosts are different.
/cc @jpbetz