activation: close files after creating listeners #215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Tiurin <noxiouz@yandex.ru>
|
Can one of the admins verify this patch? |
Contributor
|
ok to test |
Contributor
|
patch LGTM, thanks! |
Author
|
I will see |
vincentbernat
added a commit
to vincentbernat/go-systemd
that referenced
this pull request
Feb 27, 2018
This is an adaptation of coreos#215 to ensure tests don't fail and extend the behaviour to PacketConns(). A bit of test coverage is lost, but just testing if variable environments are not unset in the simple case doesn't seem worth adding more code.
vincentbernat
added a commit
to vincentbernat/go-systemd
that referenced
this pull request
Feb 27, 2018
This is an adaptation of coreos#215 to ensure tests don't fail and extend the behaviour to PacketConns(). A bit of test coverage is lost, but just testing if variable environments are not unset in the simple case doesn't seem worth adding more code. Fix coreos#215
vincentbernat
added a commit
to vincentbernat/go-systemd
that referenced
this pull request
Feb 28, 2018
This is an adaptation of coreos#215 to ensure tests don't fail and extend the behaviour to PacketConns(). A bit of test coverage is lost, but just testing if variable environments are not unset in the simple case doesn't seem worth adding more code. Fix coreos#215
Contributor
|
Closing in favor of #250. |
vincentbernat
added a commit
to vincentbernat/go-systemd
that referenced
this pull request
Mar 19, 2018
This is an adaptation of coreos#215 to ensure tests don't fail and extend the behaviour to PacketConns(). A bit of test coverage is lost, but just testing if variable environments are not unset in the simple case doesn't seem worth adding more code. Fix coreos#215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.