Skip to content

Conversation

@lucab
Copy link
Contributor

@lucab lucab commented Feb 1, 2017

This commit introduces tests exercising sending logic for
empty/small/large messages.

@lucab
Copy link
Contributor Author

lucab commented Feb 1, 2017

This is to test logic touched by #218. It seems to be currently buggy.

@lucab lucab force-pushed the to-upstream/journal-largesend-test branch 7 times, most recently from 963032b to 38e19e6 Compare February 2, 2017 14:00
@lucab lucab force-pushed the to-upstream/journal-largesend-test branch from 38e19e6 to 40d008d Compare May 23, 2018 13:19
This commit introduces tests exercising sending logic for
empty/small/large messages.
@lucab lucab force-pushed the to-upstream/journal-largesend-test branch from 40d008d to 2847fc8 Compare May 23, 2018 13:33
@lucab lucab added this to the v18 milestone May 23, 2018
@lucab
Copy link
Contributor Author

lucab commented May 25, 2018

@squeed I think we can merge this now, and uncomment the failing tests once Go 1.11 and #5 can be fixed in all supported toolchains. PTAL.

@lucab lucab changed the title journal: add some send tests test/journal: add some send tests May 25, 2018
@lucab lucab merged commit a4887ae into coreos:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants