daemon: Clean up copyright headers and documentation #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
previously requested changes
Mar 26, 2018
Contributor
lucab
left a comment
lucab
left a comment
There was a problem hiding this comment.
Just two minor stylistic comments, all the rest is 💚.
daemon/sdnotify.go
Outdated
| if err != nil { | ||
| return false, err | ||
| err := os.Unsetenv("NOTIFY_SOCKET") | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
You can merge this and the above in a single statement.
daemon/sdnotify.go
Outdated
| return false, err | ||
| } | ||
| return true, nil | ||
| return err == nil, err |
Contributor
There was a problem hiding this comment.
I would keep logic outside of return statement.
Even if I agree the original form may be overly verbose, I think it is the expected idiomatic form.
- Added copyright 2015-2018 CoreOS, Inc. - Proper godoc package comment - Got rid of named (but unused) return values Fixes coreos#83.
Contributor
Author
|
@lucab Done and squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83.