Skip to content

Conversation

@stevenjm
Copy link
Contributor

This was previously just displaying the numeric errno value, resulting in error messages like:

failed to seek to cursor "foo\n": 22

The syscall.Errno type provides a handy function for returning the string value of an error, so just use that for more informative messages.

This was previously just displaying the numeric errno value,
resulting in error messages like:

  failed to seek to cursor "foo\n": 22

The syscall.Errno type provides a handy function for returning the
string value of an error, so just use that for more informative
messages.
@lucab
Copy link
Contributor

lucab commented Jun 12, 2019

Thanks for the PR! Just for clarity, this wouldn't provide any more information about the error, right? It only does the equivalent of strerror(3) (errno int->string). Was that your goal?

@stevenjm
Copy link
Contributor Author

Correct, and indeed it is my goal. By "more informative" I meant that the message is more informative at a glance, not that there's additional information supplied.

@lucab
Copy link
Contributor

lucab commented Jun 12, 2019

@stevenjm ack, LGTM!

@lucab lucab merged commit 362f06e into coreos:master Jun 12, 2019
@lucab lucab modified the milestones: v19, v20 Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants