dbus: add support for systemd user instances #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbus/dbus.go
Outdated
Contributor
There was a problem hiding this comment.
Call it NewUserConnection, perhaps?
Contributor
Author
|
Fixed. |
dbus/dbus.go
Outdated
Contributor
There was a problem hiding this comment.
The trailing statement here looks out of place. It should be on line 98, no?
Contributor
Author
|
Ugh, yeah, I didn't notice it. Fixed now. |
Contributor
|
LGTM. @philips? |
Contributor
Author
|
Ping? |
Contributor
|
LGTM |
marineam
added a commit
that referenced
this pull request
Sep 12, 2014
dbus: add support for systemd user instances
Contributor
|
Sorry we forgot about this, merged now. :) I like this implementation better than one I did a while back. I should dust off the goo I did back then to run the unit tests against a session systemd instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new
NewUser()method in order to not break compatibility with applications usingNew(). I'm not quite sure on theNewUser()name (which is kinda confusing) tho.