Add Close method to go-systemd/dbus #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbus/dbus.go
Outdated
Contributor
There was a problem hiding this comment.
"To ensure the underlying connection is garbage collected, users should call Close() when finished with the returned Conn."
Contributor
Author
There was a problem hiding this comment.
Isn't that a bit obvious to be stating here?
Contributor
There was a problem hiding this comment.
ok, how about "Callers should Close() when done with the connection."
It's a little closer to the general convention
Contributor
|
lgtm |
vcaputo
added a commit
that referenced
this pull request
Oct 2, 2014
Add Close method to go-systemd/dbus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.