Skip to content

Helm Chart - Add support to node-exporter >= 0.15.0#754

Merged
brancz merged 2 commits intoprometheus-operator:masterfrom
pmontanari:master
Nov 14, 2017
Merged

Helm Chart - Add support to node-exporter >= 0.15.0#754
brancz merged 2 commits intoprometheus-operator:masterfrom
pmontanari:master

Conversation

@pmontanari
Copy link
Copy Markdown
Contributor

Some flags have been renamed in 0.15.0
Keeping back-compatibility with if

Some flags have been renamed in 0.15.0
Keeping back-compatibility with if
@pmontanari pmontanari changed the title Add support to node-exporter >= 0.15.0 Helm Chart - Add support to node-exporter >= 0.15.0 Nov 14, 2017
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
imagePullPolicy: "{{ .Values.image.pullPolicy }}"
args:
{{ if lt .Values.image.tag "1.15.0" }}
Copy link
Copy Markdown
Contributor

@brancz brancz Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 0.15.0

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups... Right... Fixing that

@brancz
Copy link
Copy Markdown
Contributor

brancz commented Nov 14, 2017

lgtm, thanks a lot!

@brancz brancz merged commit 014c7a2 into prometheus-operator:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants