Skip to content

Commit dc64ff3

Browse files
MartijnCuppensXhmikosR
authored andcommitted
Convert background shorthands to separate properties
1 parent 980c5fd commit dc64ff3

File tree

6 files changed

+17
-7
lines changed

6 files changed

+17
-7
lines changed

scss/_carousel.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,9 @@
128128
display: inline-block;
129129
width: $carousel-control-icon-width;
130130
height: $carousel-control-icon-width;
131-
background: no-repeat 50% / 100% 100%;
131+
background-repeat: no-repeat;
132+
background-position: 50%;
133+
background-size: 100% 100%;
132134
}
133135
.carousel-control-prev-icon {
134136
background-image: escape-svg($carousel-control-prev-icon-bg);

scss/_variables.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -704,12 +704,11 @@ $form-select-disabled-color: $gray-600 !default;
704704
$form-select-bg: $input-bg !default;
705705
$form-select-disabled-bg: $gray-200 !default;
706706
$form-select-disabled-border-color: $input-disabled-border-color !default;
707+
$form-select-bg-position: right $form-select-padding-x center !default;
707708
$form-select-bg-size: 16px 12px !default; // In pixels because image dimensions
708709
$form-select-indicator-color: $gray-800 !default;
709710
$form-select-indicator: url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 16 16'><path fill='none' stroke='#{$form-select-indicator-color}' stroke-linecap='round' stroke-linejoin='round' stroke-width='2' d='M2 5l6 6 6-6'/></svg>") !default;
710711

711-
$form-select-background: no-repeat right $form-select-padding-x center / $form-select-bg-size !default; // Used so we can have multiple background elements (e.g., arrow and feedback icon)
712-
713712
$form-select-feedback-icon-padding-right: add(1em * .75, (2 * $form-select-padding-y * .75) + $form-select-padding-x + $form-select-indicator-padding) !default;
714713
$form-select-feedback-icon-position: center right ($form-select-padding-x + $form-select-indicator-padding) !default;
715714
$form-select-feedback-icon-size: $input-height-inner-half $input-height-inner-half !default;

scss/forms/_form-select.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@
1414
line-height: $form-select-line-height;
1515
color: $form-select-color;
1616
vertical-align: middle;
17-
background: $form-select-bg escape-svg($form-select-indicator) $form-select-background;
17+
background-color: $form-select-bg;
18+
background-image: escape-svg($form-select-indicator);
19+
background-repeat: no-repeat;
20+
background-position: $form-select-bg-position;
21+
background-size: $form-select-bg-size;
1822
border: $form-select-border-width solid $form-select-border-color;
1923
@include border-radius($form-select-border-radius, 0);
2024
@include box-shadow($form-select-box-shadow);

scss/mixins/_background-variant.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33
@mixin bg-gradient-variant($parent, $color) {
44
#{$parent} {
5-
background: $color linear-gradient(180deg, mix($body-bg, $color, 15%), $color) repeat-x !important;
5+
background-image: linear-gradient(180deg, mix($body-bg, $color, 15%), $color) !important;
66
}
77
}

scss/mixins/_forms.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,9 @@
7979

8080
@if $enable-validation-icons {
8181
padding-right: $form-select-feedback-icon-padding-right;
82-
background: escape-svg($form-select-indicator) $form-select-background, escape-svg($icon) $form-select-bg no-repeat $form-select-feedback-icon-position / $form-select-feedback-icon-size;
82+
background-image: escape-svg($form-select-indicator), escape-svg($icon);
83+
background-position: $form-select-bg-position, $form-select-feedback-icon-position;
84+
background-size: $form-select-bg-size, $form-select-feedback-icon-size;
8385
}
8486

8587
&:focus {

site/assets/scss/_subnav.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@
1414
.dropdown-item.active {
1515
font-weight: 600;
1616
color: $gray-900;
17-
background: escape-svg($dropdown-active-icon) no-repeat .4rem .6rem/.75rem .75rem;
17+
background-image: escape-svg($dropdown-active-icon);
18+
background-repeat: no-repeat;
19+
background-position: .4rem .6rem;
20+
background-size: .75rem .75rem;
1821
}
1922

2023
@include media-breakpoint-up(md) {

0 commit comments

Comments
 (0)