Exception improvement: separate human beings' error and machine's error

- LogicException is a built-in exception class
- Pre-defined message for ActionNotFoundException
- Remove unnecessary constructor override

Author: c9s

src/ActionKit/Exception/ActionException.php

@@ -6,7 +6,7 @@ class ActionException extends Exception
 {
     public $action;
 
-    public function __construct( $msg , $action )
+    public function __construct($msg, $action)
     {
         $this->action = $action;
         parent::__construct($msg);

src/ActionKit/Exception/ActionNotFoundException.php

@@ -1,12 +1,13 @@
 <?php
 namespace ActionKit\Exception;
-use Exception;
+use LogicException;
 
-class ActionNotFoundException extends Exception
+class ActionNotFoundException extends LogicException
 {
+    public $actionClass;
 
-    public function __construct( $msg )
-    {
-        parent::__construct($msg);
+    public function __construct($actionClass) { 
+        $this->actionClass = $actionClass;
+        parent::__construct("Action class '$actionClass' not found, you might need to setup action autoloader or register the action template");
     }
 }

src/ActionKit/Exception/InvalidActionNameException.php

@@ -1,12 +1,7 @@
 <?php
 namespace ActionKit\Exception;
-use Exception;
+use LogicException;
 
-class InvalidActionNameException extends Exception
+class InvalidActionNameException extends LogicException
 {
-
-    public function __construct( $msg )
-    {
-        parent::__construct($msg);
-    }
 }

src/ActionKit/Exception/LogicException.php

@@ -1,12 +1,7 @@
 <?php
 namespace ActionKit\Exception;
-use Exception;
+use RuntimeException;
 
-class UnableToCreateActionException extends Exception
+class UnableToCreateActionException extends RuntimeException
 {
-
-    public function __construct( $msg )
-    {
-        parent::__construct($msg);
-    }
 }

src/ActionKit/Exception/UnableToCreateActionException.php

@@ -1,12 +1,7 @@
 <?php
 namespace ActionKit\Exception;
-use Exception;
+use RuntimeException;
 
-class UnableToWriteCacheException extends Exception
+class UnableToWriteCacheException extends RuntimeException
 {
-
-    public function __construct( $msg )
-    {
-        parent::__construct($msg);
-    }
 }

src/ActionKit/Exception/UnableToWriteCacheException.php

@@ -1,11 +1,7 @@
 <?php
 namespace ActionKit\Exception;
-use Exception;
+use LogicException;
 
-class UndefinedTemplateException extends Exception
+class UndefinedTemplateException extends LogicException
 {
-    public function __construct( $msg)
-    {
-        parent::__construct($msg);
-    }
 }