Url build alternative design #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to improve code reuse, I completely redesigned the way that URLs are built. I moved the make_url function (now renamed build_url) to the Client class. I thought this to be a better solution as opposed to having the function implemented in every child class. A few changes still need to be made in order to increase readability.
I updated the token class to comply with the new url build design.
Signed-off-by: Taylor Dawson <taylorjdawson@gmail.com>
To increase code reuse I have moved the build_url method from the child classes and into the parent class, 'Client'. I also desgined a highly pythonic way of contructing the url. The children classes are repsonible for setting the values of the api parameters that are located within the parent class.
|
It says W.I.P., are all function calls working at the moment? |
|
Yes, I had [W.I.P.] on the first commit but this pull request is complete. I ran all of the example files that you created and everything checked out. What do you think of this alternative implementation? |
|
yeah, looks great. I always appreciate code reuse. I never really liked the initial implementation but didn't spend much time thinking about reorganizing it. Great job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve code reuse, I completely redesigned the way that URLs are built.
I moved the
make_urlfunction (now renamedbuild_url) to theClientclass. I thought this to be a better solution as opposed to having the function implemented in every child class.I believe that this will also make it easier when adding additional functionality.
I tested the new design with the provided example python files and everything ran smoothly.