This repository was archived by the owner on Jan 5, 2024. It is now read-only.
CF403 Added line with thickness #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethyr
suggested changes
Mar 6, 2022
garethyr
left a comment
garethyr
left a comment
There was a problem hiding this comment.
Thanks for working on this. I've left some comments on things that need changing.
…s - much simpler and produces better result Proposed solution starts leaving gaps between individual lines when drawing at an angle (above 10 or so degrees) and is less performant due to significantly more primitive draw calls (less complex ones, but still significantly more)
garethyr
approved these changes
Oct 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #403
